Skip to content

Rebase v1.113.2#137

Merged
ske-prow[bot] merged 3 commits intoske-v1.113from
rebase-v1.113.2
Mar 21, 2025
Merged

Rebase v1.113.2#137
ske-prow[bot] merged 3 commits intoske-v1.113from
rebase-v1.113.2

Conversation

@Duciwuci
Copy link
Copy Markdown

/kind enhancement

gardener-robot-ci-1 and others added 3 commits March 21, 2025 11:46
)

Similar to
https://github.com/gardener/gardener/blob/90d1a8264468b1e3aca1a5afe33b8e6d344e94ea/pkg/component/etcd/etcd/crd.go#L70
and other places.

This is because the REST mapper might operate on stale data, i.e., when
a CRD it once discovered got deleted and it tries to list it again, the
result is a "404 Not Found" error instead of the expected "no match"
error.

Without this, the reconciler might fail:

```
{"level":"error","ts":"2025-03-19T13:00:04.820Z","msg":"Reconciler error","controller":"garbage-collector","namespace":"","name":"","reconcileID":"8dd07cc5-eec4-402b-ba0c-ccd5688fdce9","error":"Timeout: failed waiting for *v1.PartialObjectMetadata Informer to sync","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).reconcileHandler\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.20.2/pkg/internal/controller/controller.go:341\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).processNextWorkItem\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.20.2/pkg/internal/controller/controller.go:288\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).Start.func2.2\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.20.2/pkg/internal/controller/controller.go:249"}
{"level":"error","ts":"2025-03-19T12:57:06.871Z","msg":"Unhandled Error","logger":"UnhandledError","error":"pkg/mod/k8s.io/client-go@v0.32.2/tools/cache/reflector.go:251: Failed to watch *v1.PartialObjectMetadata: failed to list *v1.PartialObjectMetadata: the server could not find the requested resource","stacktrace":"k8s.io/client-go/tools/cache.DefaultWatchErrorHandler\n\t/go/pkg/mod/k8s.io/client-go@v0.32.2/tools/cache/reflector.go:166\nk8s.io/client-go/tools/cache.(*Reflector).Run.func1\n\t/go/pkg/mod/k8s.io/client-go@v0.32.2/tools/cache/reflector.go:316\nk8s.io/apimachinery/pkg/util/wait.BackoffUntil.func1\n\t/go/pkg/mod/k8s.io/apimachinery@v0.32.2/pkg/util/wait/backoff.go:226\nk8s.io/apimachinery/pkg/util/wait.BackoffUntil\n\t/go/pkg/mod/k8s.io/apimachinery@v0.32.2/pkg/util/wait/backoff.go:227\nk8s.io/client-go/tools/cache.(*Reflector).Run\n\t/go/pkg/mod/k8s.io/client-go@v0.32.2/tools/cache/reflector.go:314\nk8s.io/client-go/tools/cache.(*controller).Run.(*Group).StartWithChannel.func2\n\t/go/pkg/mod/k8s.io/apimachinery@v0.32.2/pkg/util/wait/wait.go:55\nk8s.io/apimachinery/pkg/util/wait.(*Group).Start.func1\n\t/go/pkg/mod/k8s.io/apimachinery@v0.32.2/pkg/util/wait/wait.go:72"}
{"level":"info","ts":"2025-03-19T12:57:07.847Z","msg":"pkg/mod/k8s.io/client-go@v0.32.2/tools/cache/reflector.go:251: failed to list *v1.PartialObjectMetadata: the server could not find the requested resource"}
```

Co-authored-by: rfranzke <rafael.franzke@sap.com>
@ske-prow ske-prow Bot added the kind/enhancement Enhancement, improvement, extension label Mar 21, 2025
@Duciwuci Duciwuci changed the title Rebase `v1.113.2 Rebase v1.113.2 Mar 21, 2025
@Duciwuci Duciwuci added the tide/merge-method-rebase Denotes a PR that should be rebased by tide when it merges. label Mar 21, 2025
@ske-prow ske-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 21, 2025
@lukasjarosch lukasjarosch self-requested a review March 21, 2025 13:52
@ske-prow ske-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2025
@ske-prow
Copy link
Copy Markdown

ske-prow Bot commented Mar 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lukasjarosch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ske-prow ske-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2025
@ske-prow
Copy link
Copy Markdown

ske-prow Bot commented Mar 21, 2025

LGTM label has been added.

DetailsGit tree hash: 351b0c9589fa8b4021b7d7b37b2334568cbb989d

@ske-prow ske-prow Bot merged commit c03c8b8 into ske-v1.113 Mar 21, 2025
4 checks passed
@ske-prow ske-prow Bot deleted the rebase-v1.113.2 branch March 21, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-rebase Denotes a PR that should be rebased by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants